Comments on: SimplePie Memory Leak Update

By: Vik

Vik — Sat, 20 Jun 2009 16:26:35 +0000

Thanks very much for this info, Benjie!

By: Benjie

Benjie — Sat, 20 Jun 2009 08:23:17 +0000

Hi Vik,

I’ve fixed the brackets. Its possible that this ‘fix’ is no longer necessary – it is quite old now! I don’t remember, it could be one of two things:

1) There used to be a __destruct() for SimplePie_Sanitize that isn’t there any more (in which case delete that line from the PHP), or
2) You need to implement __destruct() for SP_S (probably using similar code to the above)

Sorry I can’t look into it more, I don’t use SimplePie any more as I have no need of PHP RSS readers. Let me know how you get on!

Benjie

By: Vik

Vik — Fri, 19 Jun 2009 23:56:41 +0000

Hi Benjie,

Thanks for your reply. The missing brackets are in your sample code — could you update it? Also, even if I add them, ie. __destruct(); — I still get this error:

Call to undefined method SimplePie_Sanitize::__destruct()

How can I correct this? Thanks very much in advance for this great, much-needed fix to SimplePie!

By: Michael Shipley

Michael Shipley — Fri, 05 Sep 2008 21:42:55 +0000

Hi Benjie! I was just trying to clear up Rémi Prévost’s misconception that this was a SimplePie bug. I totally agree there needs to be a workaround for this until PHP 5.3 is released and calling the SimplePIe destruct method manually in the latest version of SimplePie (1.1.1) works partially to do that.

By: Benjie

Benjie — Fri, 05 Sep 2008 08:37:00 +0000

Vik, you need to put brackets after __destruct – i.e. __destruct(); – because it is a function not a value.

Hope this helps (probably not by now!), sorry for delay in replying – was on honeymoon when you wrote your comment, and have only just got internet at my new flat.

Benjie.

By: Benjie

Benjie — Fri, 05 Sep 2008 08:13:37 +0000

Hi Michael, I realise this (now) – but it still needs a fix/workaround for people who want to parse large numbers of feeds at once until everyone is running 5.3 (which won’t be for a long time!). It’s annoying that you have to work around the limitations and bugs of your programming language, but that is life – and there are ways to do it without memory loss. Thanks for your clarification though!

By: Michael Shipley

Michael Shipley — Fri, 05 Sep 2008 07:02:10 +0000

Hi, this is Mike from the SimplePie project. This isn’t a bug in SimplePie, it’s a bug in PHP 5.2′s GC (garbage collector). Calling __destruct is just a way to compensate for this bug. The next version of PHP, version 5.3, which is slated to be released by October 2008, should fix this.

By: Rémi Prévost

Rémi Prévost — Wed, 03 Sep 2008 18:20:58 +0000

Wow, I can’t believe they haven’t fixed the bug months after it was found! Thanks a bunch for your patch!

By: Vik

Vik — Tue, 05 Aug 2008 12:11:57 +0000

I’m getting an error at:

$this->sanitize->__destruct;

…saying:

Message: Undefined property: SimplePie_Sanitize::$__destruct

How can I correct this? Thanks very much in advance for any info.

By: Ryan Parman

Ryan Parman — Sat, 19 Apr 2008 22:10:55 +0000

In SimplePie 1.1, you need to manually call the __destruct() method before unsetting your $feed variable. Is this an alteration of the function that 1.1 shipped with? Have you posted a bug to http://bugs.simplepie.org? If so, let me know, and we’ll integrate this patch.